[regexp] restrict pattern syntax for unicode mode.

[regexp] restrict pattern syntax for unicode mode.

ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.

R=littledan@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}

Committed: https://crrev.com/bb6a53573cd05786c0a6e4a229d57f63582161c8
Cr-Commit-Position: refs/heads/master@{#33603}

[Yang, 2016-01-27 14:43:29]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 14:43:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645573002/1

[commit-bot: I haz the power, 2016-01-27 14:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 14:53:41]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Yang, 2016-01-27 16:00:12]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 16:00:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645573002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645573002/20001

[commit-bot: I haz the power, 2016-01-27 16:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 16:26:46]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-01-28 07:32:01]

Patchset #3 (id:40001) has been deleted

[Yang, 2016-01-28 07:42:43]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 07:42:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645573002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645573002/60001

[Yang, 2016-01-28 07:43:04]

yangguo@chromium.org changed reviewers:
+ vogelheim@chromium.org
- littledan@chromium.org

[Yang, 2016-01-28 07:43:04]

Daniel, could you take a look at this?

[Yang, 2016-01-28 07:59:44]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 07:59:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645573002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645573002/80001

[commit-bot: I haz the power, 2016-01-28 08:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 08:20:35]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2016-01-28 13:38:21]

lgtm

Two nitpicks about the error handling; but honestly I'm not sure I even
understand that.

https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse...
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:496: ReportError(CStrVector("Lone quantifier
brackets") CHECK_FAILED);
I don't get the point of the ReportError(... CHECK_FAILED) construct.

As I read it, ReportError set failed_ = true; and returns NULL, and CHECK_FAILED
will test for failed_ and return NULL, too. Wouldn't return ReportError(...) do
the same thing, except somewhat less unorthodox?

https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:1029: return ReportError(CStrVector(kRangeInvalid)
CHECK_FAILED);
CHECK_FAILED adds a return, after the unconditional return in this line.

[Yang, 2016-01-28 14:00:12]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-01-28 14:00:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1645573002/#ps120001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-01-28 14:00:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645573002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645573002/120001

[Yang, 2016-01-28 14:01:07]

https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse...
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:496: ReportError(CStrVector("Lone quantifier
brackets") CHECK_FAILED);
On 2016/01/28 13:38:21, vogelheim wrote:
> I don't get the point of the ReportError(... CHECK_FAILED) construct.
> 
> As I read it, ReportError set failed_ = true; and returns NULL, and
CHECK_FAILED
> will test for failed_ and return NULL, too. Wouldn't return ReportError(...)
do
> the same thing, except somewhat less unorthodox?

Done.

https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:1029: return ReportError(CStrVector(kRangeInvalid)
CHECK_FAILED);
On 2016/01/28 13:38:21, vogelheim wrote:
> CHECK_FAILED adds a return, after the unconditional return in this line.

You are completely right. I simply copied the code from other places where we
call ReportError. Fixed all of those places now.

[commit-bot: I haz the power, 2016-01-28 14:24:05]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-01-28 14:24:52]

Description was changed from

==========
[regexp] restrict pattern syntax for unicode mode.

ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.

R=littledan@chromium.org
BUG=v8:2952
LOG=N
==========

to

==========
[regexp] restrict pattern syntax for unicode mode.

ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.

R=littledan@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}
==========

[commit-bot: I haz the power, 2016-01-28 14:24:52]

Patchset 6 (id:??) landed as
https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}

[Michael Achenbach, 2016-01-28 15:26:41]

A revert of this CL (patchset #6 id:120001) has been created in
https://codereview.chromium.org/1648673002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Yang, 2016-01-28 19:12:28]

Description was changed from

==========
[regexp] restrict pattern syntax for unicode mode.

ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.

R=littledan@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}
==========

to

==========
[regexp] restrict pattern syntax for unicode mode.

ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.

R=littledan@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}
==========

[Yang, 2016-01-29 09:15:54]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-01-29 09:16:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645573002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645573002/120001

[commit-bot: I haz the power, 2016-01-29 09:21:13]

Description was changed from

==========
[regexp] restrict pattern syntax for unicode mode.

ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.

R=littledan@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}
==========

to

==========
[regexp] restrict pattern syntax for unicode mode.

ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.

R=littledan@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}
==========

[commit-bot: I haz the power, 2016-01-29 09:21:14]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-01-29 09:21:24]

Description was changed from

==========
[regexp] restrict pattern syntax for unicode mode.

ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.

R=littledan@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}
==========

to

==========
[regexp] restrict pattern syntax for unicode mode.

ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.

R=littledan@chromium.org
BUG=v8:2952
LOG=N

Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}

Committed: https://crrev.com/bb6a53573cd05786c0a6e4a229d57f63582161c8
Cr-Commit-Position: refs/heads/master@{#33603}
==========

[commit-bot: I haz the power, 2016-01-29 09:21:25]

Patchset 6 (id:??) landed as
https://crrev.com/bb6a53573cd05786c0a6e4a229d57f63582161c8
Cr-Commit-Position: refs/heads/master@{#33603}