Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1645513003: Remove simulated crash in URLRequest::DoCancel (Closed)

Created:
4 years, 11 months ago by Charlie Harrison
Modified:
4 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove simulated crash in URLRequest::DoCancel This patch removes a DumpWithoutCrashing call in DoCancel that wasn't particularly useful. BUG=557430 Committed: https://crrev.com/d680edc4ab398bcbb3df433f770bf4c2ba9ca940 Cr-Commit-Position: refs/heads/master@{#371887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M net/url_request/url_request.cc View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Charlie Harrison
This simulated crash isn't really giving us very useful data (basically just IPCs from renderer). ...
4 years, 11 months ago (2016-01-27 19:50:12 UTC) #2
mmenke
On 2016/01/27 19:50:12, csharrison wrote: > This simulated crash isn't really giving us very useful ...
4 years, 11 months ago (2016-01-27 19:55:23 UTC) #3
Charlie Harrison
Done, updated description too. Thanks!
4 years, 11 months ago (2016-01-27 19:58:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645513003/1
4 years, 11 months ago (2016-01-27 20:00:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 22:10:46 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 22:11:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d680edc4ab398bcbb3df433f770bf4c2ba9ca940
Cr-Commit-Position: refs/heads/master@{#371887}

Powered by Google App Engine
This is Rietveld 408576698