Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1645493002: [Password Manager] Enables processing invisible username fields even if visible password field was … (Closed)

Created:
4 years, 10 months ago by kolos1
Modified:
4 years, 10 months ago
Reviewers:
dvadym
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlistautofill_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Enables processing invisible username fields even if visible password field was found. BUG=554052 Committed: https://crrev.com/57c0ab7ab6189077a28f0d66a3e9c3d0e8a60a3c Cr-Commit-Position: refs/heads/master@{#371803}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -11 lines) Patch
M components/autofill/content/renderer/password_form_conversion_utils.cc View 1 2 2 chunks +46 lines, -11 lines 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kolos1
4 years, 10 months ago (2016-01-27 13:21:09 UTC) #2
dvadym
LGTM % nit https://codereview.chromium.org/1645493002/diff/20001/components/autofill/content/renderer/password_form_conversion_utils.cc File components/autofill/content/renderer/password_form_conversion_utils.cc (right): https://codereview.chromium.org/1645493002/diff/20001/components/autofill/content/renderer/password_form_conversion_utils.cc#newcode325 components/autofill/content/renderer/password_form_conversion_utils.cc:325: DCHECK(found_visible_password != nullptr); You don't need ...
4 years, 10 months ago (2016-01-27 14:05:51 UTC) #3
kolos1
https://codereview.chromium.org/1645493002/diff/20001/components/autofill/content/renderer/password_form_conversion_utils.cc File components/autofill/content/renderer/password_form_conversion_utils.cc (right): https://codereview.chromium.org/1645493002/diff/20001/components/autofill/content/renderer/password_form_conversion_utils.cc#newcode325 components/autofill/content/renderer/password_form_conversion_utils.cc:325: DCHECK(found_visible_password != nullptr); Thanks. Fixed
4 years, 10 months ago (2016-01-27 15:14:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645493002/40001
4 years, 10 months ago (2016-01-27 15:43:43 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-27 16:36:26 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 16:37:42 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/57c0ab7ab6189077a28f0d66a3e9c3d0e8a60a3c
Cr-Commit-Position: refs/heads/master@{#371803}

Powered by Google App Engine
This is Rietveld 408576698