Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1645453002: ServiceWorker: Show real process IDs in chrome://serviceworker-internals (Closed)

Created:
4 years, 11 months ago by nhiroki
Modified:
4 years, 11 months ago
Reviewers:
falken, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Show real process IDs in chrome://serviceworker-internals Before this patch, the serviceworker-internals shows a render process host ID in "Renderer process ID" entry. This is not really helpful for blink/chromium developers to debug errors related to renderer process activity. After this patch, the internal page shows a real render process ID in the entry. BUG=544760 Committed: https://crrev.com/82a9e0313504eb89ae852b145fa883d32a2b0044 Cr-Commit-Position: refs/heads/master@{#372030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M content/browser/service_worker/service_worker_internals_ui.cc View 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
nhiroki
PTAL, thanks!
4 years, 11 months ago (2016-01-27 08:34:31 UTC) #2
horo
lgtm Thank you!
4 years, 11 months ago (2016-01-27 09:54:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645453002/1
4 years, 11 months ago (2016-01-28 06:05:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 06:10:02 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 06:10:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82a9e0313504eb89ae852b145fa883d32a2b0044
Cr-Commit-Position: refs/heads/master@{#372030}

Powered by Google App Engine
This is Rietveld 408576698