Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1645443002:
[Platform] Add BT.601 and BT.709 video color profile data (Closed)
|
Created:
4 years, 11 months ago by Noel Gordon Modified:
4 years, 11 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, vmpstr+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis, enne (OOO) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
# create an array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
Committed: https://crrev.com/ea1b30c75bf726889619cc9c6d20479ce7f917a8
Cr-Commit-Position: refs/heads/master@{#371978}
Patch Set 1 #
Messages
Total messages: 17 (12 generated)
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
BUG=570150
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in bug entries #24 and #54 using a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
BUG=570150
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e"\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
==========
noel@chromium.org changed reviewers: + kbr@chromium.org
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in bug entries #24 and #54 using a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
BUG=570150
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e"\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in bug entries #24 and #54 using a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e"\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in bug entries #24 and #54 using a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e"\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in bug entries #24 and #54 using a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
lgtm
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in bug entries #24 and #54 using a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in bug entries #24 and #25 using a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645443002/1
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in bug entries #24 and #25 using a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
#create array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
# create an array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
Message was sent while issue was closed.
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
# create an array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
# create an array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
# create an array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
==========
to
==========
[Platform] Add BT.601 and BT.709 video color profile data
Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].
This data will be used in subsequent changes so no change in
behavior, no new tests.
[1] #!/bin/bash -v
# create an array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
-e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c
BUG=570150
Committed: https://crrev.com/ea1b30c75bf726889619cc9c6d20479ce7f917a8
Cr-Commit-Position: refs/heads/master@{#371978}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ea1b30c75bf726889619cc9c6d20479ce7f917a8 Cr-Commit-Position: refs/heads/master@{#371978} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
