third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h - Issue 1645433002: Basic implementation of @apply

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

Issue 1645433002: Basic implementation of @apply (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix expted.txt for failing test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

diff --git a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

index 81d69bd8ac721724e466a946dbd214cd86f6b2f6..c49b97f87c26d7d3d8f5b9f91b590b6f7d1f9b1b 100644

--- a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

+++ b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

@@ -32,12 +32,14 @@ private:

// These return false if we encounter a reference to an invalid variable with no fallback

- // Resolves a range which may contain var() references

+ // Resolves a range which may contain var() references or @apply rules

bool resolveTokenRange(CSSParserTokenRange, Vector<CSSParserToken>& result);

// Resolves the fallback (if present) of a var() reference, starting from the comma

bool resolveFallback(CSSParserTokenRange, Vector<CSSParserToken>& result);

// Resolves the contents of a var() reference

bool resolveVariableReference(CSSParserTokenRange, Vector<CSSParserToken>& result);

+ // Consumes and resolves an @apply rule

+ void resolveApplyAtRule(CSSParserTokenRange&, Vector<CSSParserToken>& result);

// These return null if the custom property is invalid