third_party/WebKit/Source/build/scripts/make_css_property_names.py - Issue 1645433002: Basic implementation of @apply

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_css_property_names.py

Issue 1645433002: Basic implementation of @apply (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix expted.txt for failing test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/build/scripts/make_css_property_names.py

diff --git a/third_party/WebKit/Source/build/scripts/make_css_property_names.py b/third_party/WebKit/Source/build/scripts/make_css_property_names.py

index 5bdaa1c55ae3d3cfad22c4b3531f8d487e03e01b..2360d0cfd9b8bcad3a5dea55f282fac0b2bbba11 100755

--- a/third_party/WebKit/Source/build/scripts/make_css_property_names.py

+++ b/third_party/WebKit/Source/build/scripts/make_css_property_names.py

@@ -28,7 +28,9 @@ namespace blink {

enum CSSPropertyID {

CSSPropertyInvalid = 0,

- CSSPropertyVariable = 1,

+ // This isn't a property, but we need to know the position of @apply rules in style rules

+ CSSPropertyApplyAtRule = 1,

+ CSSPropertyVariable = 2,

%(property_enums)s

};

@@ -45,7 +47,7 @@ WTF::String getJSPropertyName(CSSPropertyID);

inline CSSPropertyID convertToCSSPropertyID(int value)

{

- ASSERT((value >= firstCSSProperty && value <= lastCSSProperty) || value == CSSPropertyInvalid || value == CSSPropertyVariable);

+ ASSERT(value >= CSSPropertyInvalid && value <= lastCSSProperty);

return static_cast<CSSPropertyID>(value);

}