Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 1645423002: Return an error in many service RPCs if the isolate is not runnable (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/json_stream.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 // Some value smaller than the object ring, so requesting a large array 7 // Some value smaller than the object ring, so requesting a large array
8 // doesn't result in an expired ref because the elements lapped it in the 8 // doesn't result in an expired ref because the elements lapped it in the
9 // object ring. 9 // object ring.
10 const int kDefaultFieldLimit = 100; 10 const int kDefaultFieldLimit = 100;
(...skipping 23 matching lines...) Expand all
34 static const kParseError = -32700; 34 static const kParseError = -32700;
35 static const kInvalidRequest = -32600; 35 static const kInvalidRequest = -32600;
36 static const kMethodNotFound = -32601; 36 static const kMethodNotFound = -32601;
37 static const kInvalidParams = -32602; 37 static const kInvalidParams = -32602;
38 static const kInternalError = -32603; 38 static const kInternalError = -32603;
39 static const kFeatureDisabled = 100; 39 static const kFeatureDisabled = 100;
40 static const kVMMustBePaused = 101; 40 static const kVMMustBePaused = 101;
41 static const kCannotAddBreakpoint = 102; 41 static const kCannotAddBreakpoint = 102;
42 static const kStreamAlreadySubscribed = 103; 42 static const kStreamAlreadySubscribed = 103;
43 static const kStreamNotSubscribed = 104; 43 static const kStreamNotSubscribed = 104;
44 static const kIsolateMustBeRunnable = 105;
44 45
45 int code; 46 int code;
46 Map data; 47 Map data;
47 48
48 static _getMessage(Map errorMap) { 49 static _getMessage(Map errorMap) {
49 Map data = errorMap['data']; 50 Map data = errorMap['data'];
50 if (data != null && data['details'] != null) { 51 if (data != null && data['details'] != null) {
51 return data['details']; 52 return data['details'];
52 } else { 53 } else {
53 return errorMap['message']; 54 return errorMap['message'];
(...skipping 3974 matching lines...) Expand 10 before | Expand all | Expand 10 after
4028 var v = list[i]; 4029 var v = list[i];
4029 if ((v is ObservableMap) && _isServiceMap(v)) { 4030 if ((v is ObservableMap) && _isServiceMap(v)) {
4030 list[i] = owner.getFromMap(v); 4031 list[i] = owner.getFromMap(v);
4031 } else if (v is ObservableList) { 4032 } else if (v is ObservableList) {
4032 _upgradeObservableList(v, owner); 4033 _upgradeObservableList(v, owner);
4033 } else if (v is ObservableMap) { 4034 } else if (v is ObservableMap) {
4034 _upgradeObservableMap(v, owner); 4035 _upgradeObservableMap(v, owner);
4035 } 4036 }
4036 } 4037 }
4037 } 4038 }
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/json_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698