Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 164539: Linux: Update PRIMARY selection on omnibox copy-to-clipboard. (Closed)

Created:
11 years, 4 months ago by Daniel Erat
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Evan Martin
Visibility:
Public.

Description

Linux: Update PRIMARY selection on omnibox copy-to-clipboard. This brings us in line with Firefox's behavior. Ctrl-L highlights the URL but doesn't update the PRIMARY selection, so Ctrl-C is a common* way to get the current location into PRIMARY so you can middle-click somewhere else to paste it. * I use it and a user mentioned that they do too. :-P Tested as follows: - highlight some text on the page to make it PRIMARY - hit Ctrl-L and confirm that text on page is still PRIMARY - hit Ctrl-C and confirm that location is now PRIMARY - repeat, but this time hit the right arrow key between Ctrl-L and Ctrl-C to unhighlight the text first. the text on the page should remain the PRIMARY selection BUG=18403 TESTED=see above

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
11 years, 4 months ago (2009-08-14 00:32:00 UTC) #1
Evan Stade
lgtm
11 years, 4 months ago (2009-08-14 00:33:37 UTC) #2
Daniel Erat
Forgot to mention, but I intentionally didn't hook up the cut signal. It seems more ...
11 years, 4 months ago (2009-08-14 00:33:58 UTC) #3
Dean McNamee
11 years, 4 months ago (2009-08-14 00:35:55 UTC) #4
Okay

Powered by Google App Engine
This is Rietveld 408576698