Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1645333003: Ensure that the code in the DXVA DX11 decoder which can potentially access the DX11 device context … (Closed)

Created:
4 years, 10 months ago by ananta
Modified:
4 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Merging to M48 Ensure that the code in the DXVA DX11 decoder which can potentially access the DX11 device context on the decoder thread is locked with the ID3D10Multithread interface. The ProcessInput call on the color converter does access the DX11 device context on the decoder thread to check states. This currently executes outside the lock. Moving it inside the lock. With this change the color converter ProcessInput and ProcessOutput calls are in the lock. Added a class AutoDX11DeviceLock to make the locking more seamless. The other change is to get rid of the begin streaming calls for the converter and the Flush calls on the context. These are not necessary now with the single device If this does not fix the Win8 bot flakiness the last step to try would be to move the copy texture call to the main thread. Failing that we need to go back to the two device model. All symptoms here point to an NVIDIA driver quirk. BUG=548383 TBR=dalecurtis Committed: https://chromium.googlesource.com/chromium/src/+/60f74b113dfe62404e80e0899beda85e4f7c538f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -44 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 8 chunks +28 lines, -42 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
ananta
4 years, 10 months ago (2016-01-30 02:25:03 UTC) #3
ananta
4 years, 10 months ago (2016-01-30 02:28:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
60f74b113dfe62404e80e0899beda85e4f7c538f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698