third_party/WebKit/LayoutTests/http/tests/svg/svg-in-object-in-sandboxed-iframe.html - Issue 1645313002: Don't apply the SandboxPlugins flag until we know a plugin will be used

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/svg/svg-in-object-in-sandboxed-iframe.html

Issue 1645313002: Don't apply the SandboxPlugins flag until we know a plugin will be used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Side-effecting assert == bad Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/svg/resources/object-svg.html ('k') | third_party/WebKit/LayoutTests/http/tests/svg/svg-in-object-in-sandboxed-iframe-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner)

	4 testRunner.waitUntilDone();

	5 function finishTest() {

	6 if (window.testRunner)

	7 testRunner.notifyDone();

	8 }
	Mike West 2016/02/24 13:30:55 You could turn this into a `testharness`-style tes You could turn this into a `testharness`-style test that would also work in Firefox, et al. if you listened for a message from `object-svg.html`, and then reached into that frame to verify the resulting DOM (and `error`/`load` handlers on the `object`). fs 2016/02/24 17:57:16 Done. Show quoted text On 2016/02/24 at 13:30:55, Mike West wrote: > You could turn this into a `testharness`-style test that would also work in Firefox, et al. if you listened for a message from `object-svg.html`, and then reached into that frame to verify the resulting DOM (and `error`/`load` handlers on the `object`). Done.
	9 </script>

	10 <iframe sandbox src="resources/object-svg.html"
	Mike West 2016/02/24 13:30:55 You'd need to add `allow-same-origin` to do so. You'd need to add `allow-same-origin` to do so. fs 2016/02/24 17:57:16 And 'allow-scripts' too I guess. Show quoted text On 2016/02/24 at 13:30:55, Mike West wrote: > You'd need to add `allow-same-origin` to do so. And 'allow-scripts' too I guess.
	11 style="border: none; margin: 0"

	12 scrolling="no"

	13 onload="finishTest()"></iframe>

OLD	NEW