Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: test/mjsunit/array-constructor-feedback.js

Issue 16453002: Removed flag optimize-constructed-arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comment fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/allocation-site-info.js ('k') | test/mjsunit/array-feedback.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 19 matching lines...) Expand all
30 30
31 // Test element kind of objects. 31 // Test element kind of objects.
32 // Since --smi-only-arrays affects builtins, its default setting at compile 32 // Since --smi-only-arrays affects builtins, its default setting at compile
33 // time sticks if built with snapshot. If --smi-only-arrays is deactivated 33 // time sticks if built with snapshot. If --smi-only-arrays is deactivated
34 // by default, only a no-snapshot build actually has smi-only arrays enabled 34 // by default, only a no-snapshot build actually has smi-only arrays enabled
35 // in this test case. Depending on whether smi-only arrays are actually 35 // in this test case. Depending on whether smi-only arrays are actually
36 // enabled, this test takes the appropriate code path to check smi-only arrays. 36 // enabled, this test takes the appropriate code path to check smi-only arrays.
37 37
38 // support_smi_only_arrays = %HasFastSmiElements(new Array(1,2,3,4,5,6,7,8)); 38 // support_smi_only_arrays = %HasFastSmiElements(new Array(1,2,3,4,5,6,7,8));
39 support_smi_only_arrays = true; 39 support_smi_only_arrays = true;
40 optimize_constructed_arrays = true;
41 40
42 if (support_smi_only_arrays) { 41 if (support_smi_only_arrays) {
43 print("Tests include smi-only arrays."); 42 print("Tests include smi-only arrays.");
44 } else { 43 } else {
45 print("Tests do NOT include smi-only arrays."); 44 print("Tests do NOT include smi-only arrays.");
46 } 45 }
47 46
48 if (optimize_constructed_arrays) {
49 print("Tests include constructed array optimizations.");
50 } else {
51 print("Tests do NOT include constructed array optimizations.");
52 }
53
54 var elements_kind = { 47 var elements_kind = {
55 fast_smi_only : 'fast smi only elements', 48 fast_smi_only : 'fast smi only elements',
56 fast : 'fast elements', 49 fast : 'fast elements',
57 fast_double : 'fast double elements', 50 fast_double : 'fast double elements',
58 dictionary : 'dictionary elements', 51 dictionary : 'dictionary elements',
59 external_byte : 'external byte elements', 52 external_byte : 'external byte elements',
60 external_unsigned_byte : 'external unsigned byte elements', 53 external_unsigned_byte : 'external unsigned byte elements',
61 external_short : 'external short elements', 54 external_short : 'external short elements',
62 external_unsigned_short : 'external unsigned short elements', 55 external_unsigned_short : 'external unsigned short elements',
63 external_int : 'external int elements', 56 external_int : 'external int elements',
(...skipping 16 matching lines...) Expand all
80 } 73 }
81 74
82 function assertKind(expected, obj, name_opt) { 75 function assertKind(expected, obj, name_opt) {
83 if (!support_smi_only_arrays && 76 if (!support_smi_only_arrays &&
84 expected == elements_kind.fast_smi_only) { 77 expected == elements_kind.fast_smi_only) {
85 expected = elements_kind.fast; 78 expected = elements_kind.fast;
86 } 79 }
87 assertEquals(expected, getKind(obj), name_opt); 80 assertEquals(expected, getKind(obj), name_opt);
88 } 81 }
89 82
90 if (support_smi_only_arrays && optimize_constructed_arrays) { 83 if (support_smi_only_arrays) {
91 function bar0(t) { 84 function bar0(t) {
92 return new t(); 85 return new t();
93 } 86 }
94 87
95 a = bar0(Array); 88 a = bar0(Array);
96 a[0] = 3.5; 89 a[0] = 3.5;
97 b = bar0(Array); 90 b = bar0(Array);
98 assertKind(elements_kind.fast_double, b); 91 assertKind(elements_kind.fast_double, b);
99 %OptimizeFunctionOnNextCall(bar0); 92 %OptimizeFunctionOnNextCall(bar0);
100 b = bar0(Array); 93 b = bar0(Array);
101 assertKind(elements_kind.fast_double, b); 94 assertKind(elements_kind.fast_double, b);
102 assertTrue(2 != %GetOptimizationStatus(bar0)); 95 assertTrue(2 != %GetOptimizationStatus(bar0));
103 // bar0 should deopt 96 // bar0 should deopt
104 b = bar0(Object); 97 b = bar0(Object);
105 assertTrue(1 != %GetOptimizationStatus(bar0)); 98 assertTrue(1 != %GetOptimizationStatus(bar0));
106 } 99 }
OLDNEW
« no previous file with comments | « test/mjsunit/allocation-site-info.js ('k') | test/mjsunit/array-feedback.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698