Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 16453002: Removed flag optimize-constructed-arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comment fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4030 matching lines...) Expand 10 before | Expand all | Expand 10 after
4041 CALL_AS_FUNCTION, 4041 CALL_AS_FUNCTION,
4042 A1_UNINITIALIZED); 4042 A1_UNINITIALIZED);
4043 } 4043 }
4044 4044
4045 4045
4046 void LCodeGen::DoCallNew(LCallNew* instr) { 4046 void LCodeGen::DoCallNew(LCallNew* instr) {
4047 ASSERT(ToRegister(instr->constructor()).is(a1)); 4047 ASSERT(ToRegister(instr->constructor()).is(a1));
4048 ASSERT(ToRegister(instr->result()).is(v0)); 4048 ASSERT(ToRegister(instr->result()).is(v0));
4049 4049
4050 __ li(a0, Operand(instr->arity())); 4050 __ li(a0, Operand(instr->arity()));
4051 if (FLAG_optimize_constructed_arrays) { 4051 // No cell in a2 for construct type feedback in optimized code
4052 // No cell in a2 for construct type feedback in optimized code 4052 Handle<Object> undefined_value(isolate()->factory()->undefined_value());
4053 Handle<Object> undefined_value(isolate()->heap()->undefined_value(), 4053 __ li(a2, Operand(undefined_value));
4054 isolate());
4055 __ li(a2, Operand(undefined_value));
4056 }
4057 CallConstructStub stub(NO_CALL_FUNCTION_FLAGS); 4054 CallConstructStub stub(NO_CALL_FUNCTION_FLAGS);
4058 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 4055 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
4059 } 4056 }
4060 4057
4061 4058
4062 void LCodeGen::DoCallNewArray(LCallNewArray* instr) { 4059 void LCodeGen::DoCallNewArray(LCallNewArray* instr) {
4063 ASSERT(ToRegister(instr->constructor()).is(a1)); 4060 ASSERT(ToRegister(instr->constructor()).is(a1));
4064 ASSERT(ToRegister(instr->result()).is(v0)); 4061 ASSERT(ToRegister(instr->result()).is(v0));
4065 ASSERT(FLAG_optimize_constructed_arrays);
4066 4062
4067 __ li(a0, Operand(instr->arity())); 4063 __ li(a0, Operand(instr->arity()));
4068 __ li(a2, Operand(instr->hydrogen()->property_cell())); 4064 __ li(a2, Operand(instr->hydrogen()->property_cell()));
4069 ElementsKind kind = instr->hydrogen()->elements_kind(); 4065 ElementsKind kind = instr->hydrogen()->elements_kind();
4070 bool disable_allocation_sites = 4066 bool disable_allocation_sites =
4071 (AllocationSiteInfo::GetMode(kind) == TRACK_ALLOCATION_SITE); 4067 (AllocationSiteInfo::GetMode(kind) == TRACK_ALLOCATION_SITE);
4072 4068
4073 if (instr->arity() == 0) { 4069 if (instr->arity() == 0) {
4074 ArrayNoArgumentConstructorStub stub(kind, disable_allocation_sites); 4070 ArrayNoArgumentConstructorStub stub(kind, disable_allocation_sites);
4075 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 4071 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
(...skipping 1844 matching lines...) Expand 10 before | Expand all | Expand 10 after
5920 __ Subu(scratch, result, scratch); 5916 __ Subu(scratch, result, scratch);
5921 __ lw(result, FieldMemOperand(scratch, 5917 __ lw(result, FieldMemOperand(scratch,
5922 FixedArray::kHeaderSize - kPointerSize)); 5918 FixedArray::kHeaderSize - kPointerSize));
5923 __ bind(&done); 5919 __ bind(&done);
5924 } 5920 }
5925 5921
5926 5922
5927 #undef __ 5923 #undef __
5928 5924
5929 } } // namespace v8::internal 5925 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698