[interpreter] Reachability is implied by live environment.

test/cctest/compiler/test-run-bytecode-graph-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "src/compiler/pipeline.h"
 #include "src/execution.h"
 #include "src/handles.h"
 #include "src/interpreter/bytecode-array-builder.h"
@@ skipping 1400 matching lines @@
     CHECK(return_value->SameValue(*snippets[i].return_value()));
   }
 }
 
 TEST(BytecodeGraphBuilderTryCatch) {
   HandleAndZoneScope scope;
   Isolate* isolate = scope.main_isolate();
   Zone* zone = scope.main_zone();
 
   ExpectedSnippet<0> snippets[] = {
-      // TODO(mstarzinger): Fix cases where nothing throws.
-      // {"var a = 1; try { a = 2 } catch(e) { a = 3 }; return a;",
-      //  {handle(Smi::FromInt(2), isolate)}},
+      {"var a = 1; try { a = 2 } catch(e) { a = 3 }; return a;",
+       {handle(Smi::FromInt(2), isolate)}},
       {"var a; try { undef.x } catch(e) { a = 2 }; return a;",
        {handle(Smi::FromInt(2), isolate)}},
       {"var a; try { throw 1 } catch(e) { a = e + 2 }; return a;",
        {handle(Smi::FromInt(3), isolate)}},
       {"var a; try { throw 1 } catch(e) { a = e + 2 };"
        "       try { throw a } catch(e) { a = e + 3 }; return a;",
        {handle(Smi::FromInt(6), isolate)}},
   };
 
   size_t num_snippets = sizeof(snippets) / sizeof(snippets[0]);
@@ skipping 10 matching lines @@
 }
 
 TEST(BytecodeGraphBuilderTryFinally1) {
   HandleAndZoneScope scope;
   Isolate* isolate = scope.main_isolate();
   Zone* zone = scope.main_zone();
 
   ExpectedSnippet<0> snippets[] = {
       {"var a = 1; try { a = a + 1; } finally { a = a + 2; }; return a;",
        {handle(Smi::FromInt(4), isolate)}},
-      // TODO(mstarzinger): Fix cases where nothing throws.
-      // {"var a = 1; try { a = 2; return 23; } finally { a = 3 }; return a;",
-      //  {handle(Smi::FromInt(23), isolate)}},
+      {"var a = 1; try { a = 2; return 23; } finally { a = 3 }; return a;",
+       {handle(Smi::FromInt(23), isolate)}},
       {"var a = 1; try { a = 2; throw 23; } finally { return a; };",
        {handle(Smi::FromInt(2), isolate)}},
-      // {"var a = 1; for (var i = 10; i < 20; i += 5) {"
-      //  "  try { a = 2; break; } finally { a = 3; }"
-      //  "} return a + i;",
-      //  {handle(Smi::FromInt(13), isolate)}},
-      // {"var a = 1; for (var i = 10; i < 20; i += 5) {"
-      //  "  try { a = 2; continue; } finally { a = 3; }"
-      //  "} return a + i;",
-      //  {handle(Smi::FromInt(23), isolate)}},
+      {"var a = 1; for (var i = 10; i < 20; i += 5) {"
+       "  try { a = 2; break; } finally { a = 3; }"
+       "} return a + i;",
+       {handle(Smi::FromInt(13), isolate)}},
+      {"var a = 1; for (var i = 10; i < 20; i += 5) {"
+       "  try { a = 2; continue; } finally { a = 3; }"
+       "} return a + i;",
+       {handle(Smi::FromInt(23), isolate)}},
+      // TODO(mstarzinger): Investigate failure!
       // {"var a = 1; try { a = 2;"
       //  "  try { a = 3; throw 23; } finally { a = 4; }"
       //  "} catch(e) { a = a + e; } return a;",
       //  {handle(Smi::FromInt(27), isolate)}},
   };
 
   size_t num_snippets = sizeof(snippets) / sizeof(snippets[0]);
   for (size_t i = 0; i < num_snippets; i++) {
     ScopedVector<char> script(1024);
     SNPrintF(script, "function %s() { %s }\n%s();", kFunctionName,
@@ skipping 1152 matching lines @@
     Handle<Object> return_value = callable().ToHandleChecked();
     CHECK(return_value->SameValue(*snippets[i].return_value()));
   }
 
   FLAG_harmony_do_expressions = old_flag;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8