Issue 164528: Prevent mouse down events on the toolbar view from moving the parent window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164528: Prevent mouse down events on the toolbar view from moving the parent window (Closed)

Created:
11 years, 4 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Prevent mouse down events on the toolbar view from moving the parent window. BUG=19305 (http://crbug.com/19305) TEST=Click and drag on the toolbar background and ensure that the window isn't moved. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23453

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
M	chrome/browser/cocoa/toolbar_view.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_view.mm	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_view_unittest.mm	View	1	1 chunk	+21 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Paul Godavari

Decided not to make a common base class, since ToolbarView subclasses BackgroundGradientView which is used ...

11 years, 4 months ago (2009-08-14 17:31:40 UTC) #1

John Grabowski

On 2009/08/14 17:31:40, Paul Godavari wrote: > Decided not to make a common base class, ...

11 years, 4 months ago (2009-08-14 17:46:56 UTC) #2

LGTM