rewrite_to_chrome_style: tweak macro ignoring logic.

rewrite_to_chrome_style: tweak macro ignoring logic.

If the name is defined from a macro (e.g. using something like
DEFINE_TYPE_CASTS), then the rewriter should ignore it: macros generally
need to be manually updated to avoid massive compile breakage.

On the other hand, an identifier appearing in the invocation of a
function-like macro should still be rewritten.

The updated logic only skips rewriting if the declaration referenced by
the identifier originates from a macro expansion; otherwise, it will
rewrite the identifier to the new name.

BUG=581902
Committed: https://crrev.com/21f01682a450f0df6ddcfaba715b5d2078c12d91
Cr-Commit-Position: refs/heads/master@{#372276}

[dcheng, 2016-01-29 01:55:29]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-01-29 01:59:51]

LGTM

[dcheng, 2016-01-29 02:46:41]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-01-29 02:46:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645263002/60001

[commit-bot: I haz the power, 2016-01-29 03:23:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-29 03:24:09]

Description was changed from

==========
rewrite_to_chrome_style: tweak macro ignoring logic.

If the name is defined from a macro (e.g. using something like
DEFINE_TYPE_CASTS), then the rewriter should ignore it: macros generally
need to be manually updated to avoid massive compile breakage.

On the other hand, an identifier appearing in the invocation of a
function-like macro should still be rewritten.

The updated logic only skips rewriting if the declaration referenced by
the identifier originates from a macro expansion; otherwise, it will
rewrite the identifier to the new name.

BUG=581902
==========

to

==========
rewrite_to_chrome_style: tweak macro ignoring logic.

If the name is defined from a macro (e.g. using something like
DEFINE_TYPE_CASTS), then the rewriter should ignore it: macros generally
need to be manually updated to avoid massive compile breakage.

On the other hand, an identifier appearing in the invocation of a
function-like macro should still be rewritten.

The updated logic only skips rewriting if the declaration referenced by
the identifier originates from a macro expansion; otherwise, it will
rewrite the identifier to the new name.

BUG=581902

Committed: https://crrev.com/21f01682a450f0df6ddcfaba715b5d2078c12d91
Cr-Commit-Position: refs/heads/master@{#372276}
==========

[commit-bot: I haz the power, 2016-01-29 03:24:10]

Patchset 4 (id:??) landed as
https://crrev.com/21f01682a450f0df6ddcfaba715b5d2078c12d91
Cr-Commit-Position: refs/heads/master@{#372276}