Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1645243002: rewrite_to_chrome_style: Avoid asserts when checking for const-ness. (Closed)

Created:
4 years, 10 months ago by danakj
Modified:
4 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite_to_chrome_style: Avoid asserts when checking for const-ness. Just skip expressions that are dependent on template parameters, treat them as non-constant. R=dcheng BUG=581218 Committed: https://crrev.com/ff937edd31103810aef4a934f932d49c60b05cfc Cr-Commit-Position: refs/heads/master@{#372256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/clang/rewrite_to_chrome_style/tests/template-expected.cc View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/clang/rewrite_to_chrome_style/tests/template-original.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
danakj
4 years, 10 months ago (2016-01-29 00:15:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645243002/1
4 years, 10 months ago (2016-01-29 00:16:18 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-29 00:50:50 UTC) #5
dcheng
lgtm
4 years, 10 months ago (2016-01-29 02:07:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645243002/1
4 years, 10 months ago (2016-01-29 02:17:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 02:24:20 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 02:26:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff937edd31103810aef4a934f932d49c60b05cfc
Cr-Commit-Position: refs/heads/master@{#372256}

Powered by Google App Engine
This is Rietveld 408576698