Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1645223003: Fix Unicode string normalization with null bytes (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, domenic
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Unicode string normalization with null bytes Previously, String.prototype.normalize constructed its ICU input string as a null-terminated string. This creates a bug for strings which contain a null byte, which is allowed in ECMAScript. This patch constructs the ICU string based on its length so that the entire string is normalized. R=jshin@chromium.org BUG=v8:4654 LOG=Y Committed: https://crrev.com/f3e41d96dd36acba861150c9c5c1e83f427ff196 Cr-Commit-Position: refs/heads/master@{#33614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M src/runtime/runtime-i18n.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-4654.js View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645223003/1
4 years, 10 months ago (2016-01-28 23:28:05 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 23:52:22 UTC) #4
jungshik at Google
LGTM
4 years, 10 months ago (2016-01-29 07:14:14 UTC) #5
Yang
On 2016/01/29 07:14:14, jshin (jungshik at google) wrote: > LGTM lgtm.
4 years, 10 months ago (2016-01-29 07:22:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645223003/1
4 years, 10 months ago (2016-01-29 16:58:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 17:00:20 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 17:00:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3e41d96dd36acba861150c9c5c1e83f427ff196
Cr-Commit-Position: refs/heads/master@{#33614}

Powered by Google App Engine
This is Rietveld 408576698