Identity API: handle window.open events from the scope approval webview

chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js

Index: chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js
diff --git a/chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js b/chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js
index b495e8c570833f95a55b6b8bdc4100c0e491f3ee..536b01d79cdbc9f781dc35103d436fdcc345d592 100644
--- a/chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js
+++ b/chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js
@@ -13,6 +13,13 @@ var webview;
  *     window.
  */
 function loadAuthUrlAndShowWindow(url, win) {
+  // Send popups from the webview to a normal browser window.
+  webview.addEventListener('newwindow', function(e) {
+    e.preventDefault();

[Fady Samuel, 2013/06/12 20:45:45]

e.window.discard(); is more appropriate.

e.preventDefault() will put the new window in the hands of the garbage collector
and will end up eating more memory until the garbage collector decides it's time
to collect.

e.window.discard() will discard the new window immediately.

[Michael Courage, 2013/06/12 20:54:30]

Done. That's good to know, thanks.

+    window.open(e.targetUrl);
+  });
+
+  // Request a customized view from GAIA.
   webview.onBeforeSendHeaders.addListener(function(details) {
     headers = details.requestHeaders || [];
     headers.push({'name': 'X-Browser-View',
@@ -21,6 +28,7 @@ function loadAuthUrlAndShowWindow(url, win) {
   }, {
     urls: ['https://accounts.google.com/*'],
   }, ['blocking', 'requestHeaders']);
+
   webview.src = url;
   if (win) {
     webview.addEventListener('loadstop', function() {