Identity API: handle window.open events from the scope approval webview

Identity API: handle window.open events from the scope approval webview

This change causes the "Learn More" links in our auth flows to open in
a normal browser tab (instead of being suppressed entirely).

BUG=248165
TEST=manual click "Learn More" in gaia flow invoked by identity.getAuthToken

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206284

[Fady Samuel, 2013-06-12 20:45:45]

https://codereview.chromium.org/16452017/diff/4001/chrome/browser/resources/i...
File
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js
(right):

https://codereview.chromium.org/16452017/diff/4001/chrome/browser/resources/i...
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js:18:
e.preventDefault();
e.window.discard(); is more appropriate.

e.preventDefault() will put the new window in the hands of the garbage collector
and will end up eating more memory until the garbage collector decides it's time
to collect.

e.window.discard() will discard the new window immediately.

[Michael Courage, 2013-06-12 20:54:29]

https://codereview.chromium.org/16452017/diff/4001/chrome/browser/resources/i...
File
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js
(right):

https://codereview.chromium.org/16452017/diff/4001/chrome/browser/resources/i...
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js:18:
e.preventDefault();
On 2013/06/12 20:45:45, Fady Samuel wrote:
> e.window.discard(); is more appropriate.
> 
> e.preventDefault() will put the new window in the hands of the garbage
collector
> and will end up eating more memory until the garbage collector decides it's
time
> to collect.
> 
> e.window.discard() will discard the new window immediately.

Done. That's good to know, thanks.

[Michael Courage, 2013-06-13 21:10:15]

ping xiyuan, can you have a look at this?

[xiyuan, 2013-06-13 21:16:06]

LGTM

Sorry for the delay.

[commit-bot: I haz the power, 2013-06-13 21:44:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/16452017/8001

[commit-bot: I haz the power, 2013-06-14 03:38:05]

Change committed as 206284