chrome/OWNERS - Issue 16452016: Drop obsolete comment from chrome/OWNERS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/OWNERS

Issue 16452016: Drop obsolete comment from chrome/OWNERS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # This OWNERS list is a last resort. Please prefer to use more specific OWNERS	1 # This OWNERS list is a last resort. Please prefer to use more specific OWNERS

2 # where possible.	2 # where possible.

3	3

4 # Reviewers:	4 # Reviewers:

5 jochen@chromium.org	5 jochen@chromium.org

6 jhawkins@chromium.org	6 jhawkins@chromium.org

7 sky@chromium.org	7 sky@chromium.org

8 thakis@chromium.org	8 thakis@chromium.org

9 thestig@chromium.org	9 thestig@chromium.org

10	10

(...skipping 27 matching lines...) Expand all Loading...
38 per-file chrome_browser_chromeos.gypi=davemoore@chromium.org	38 per-file chrome_browser_chromeos.gypi=davemoore@chromium.org

39 per-file chrome_browser_chromeos.gypi=derat@chromium.org	39 per-file chrome_browser_chromeos.gypi=derat@chromium.org

40 per-file chrome_browser_chromeos.gypi=dpolukhin@chromium.org	40 per-file chrome_browser_chromeos.gypi=dpolukhin@chromium.org

41 per-file chrome_browser_chromeos.gypi=nkostylev@chromium.org	41 per-file chrome_browser_chromeos.gypi=nkostylev@chromium.org

42 per-file chrome_browser_chromeos.gypi=oshima@chromium.org	42 per-file chrome_browser_chromeos.gypi=oshima@chromium.org

43 per-file chrome_browser_chromeos.gypi=satorux@chromium.org	43 per-file chrome_browser_chromeos.gypi=satorux@chromium.org

44 per-file chrome_browser_chromeos.gypi=stevenjb@chromium.org	44 per-file chrome_browser_chromeos.gypi=stevenjb@chromium.org

45 per-file chrome_browser_chromeos.gypi=xiyuan@chromium.org	45 per-file chrome_browser_chromeos.gypi=xiyuan@chromium.org

46 per-file chrome_browser_chromeos.gypi=zelidrag@chromium.org	46 per-file chrome_browser_chromeos.gypi=zelidrag@chromium.org

47	47

48 # If you just remove, rename, or add a file to a non-test gypi file,	48 # If you just remove, rename, or add a file to a gypi file,
	jochen (gone - plz use gerrit) 2013/06/12 10:04:37 please remove the entire comment block. It referre please remove the entire comment block. It referred to rules that are no longer in this files. There's a per-file .gypi= rule in line 18, so you don't need to TBR file adding/removing files (as the comment in line 16/17 states) kinuko 2013/06/12 10:13:35 Done. Show quoted text On 2013/06/12 10:04:37, jochen wrote: > please remove the entire comment block. It referred to rules that are no longer > in this files. > > There's a per-file .gypi= rule in line 18, so you don't need to TBR file > adding/removing files (as the comment in line 16/17 states) Done.
49 # you can land that change TBR. Make sure to still add the people	49 # you can land that change TBR. Make sure to still add the people

50 # you're TBRing to the review thread and to send them email.	50 # you're TBRing to the review thread and to send them email.

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »