Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: testing/test_env.py

Issue 1645183003: Make path to asan_symbolize.py absolute in test_env.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test_env.py
diff --git a/testing/test_env.py b/testing/test_env.py
index 052df6769b262c442a5b8721ae38c166c659c0b8..0513e1a0fd96c2d1dc58e3eb3128ee96651a5e7d 100755
--- a/testing/test_env.py
+++ b/testing/test_env.py
@@ -65,8 +65,8 @@ def get_sanitizer_env(cmd, asan, lsan, msan, tsan):
# TODO(glider): remove the symbolizer path once
# https://code.google.com/p/address-sanitizer/issues/detail?id=134 is fixed.
- symbolizer_path = os.path.abspath(os.path.join(ROOT_DIR, 'third_party',
- 'llvm-build', 'Release+Asserts', 'bin', 'llvm-symbolizer'))
+ symbolizer_path = os.path.join(ROOT_DIR,
+ 'third_party', 'llvm-build', 'Release+Asserts', 'bin', 'llvm-symbolizer')
if lsan or tsan:
# LSan is not sandbox-compatible, so we can use online symbolization. In
@@ -125,7 +125,8 @@ def get_sanitizer_env(cmd, asan, lsan, msan, tsan):
def get_sanitizer_symbolize_command(json_path=None, executable_path=None):
"""Construct the command to invoke offline symbolization script."""
- script_path = '../tools/valgrind/asan/asan_symbolize.py'
+ script_path = os.path.join(
+ ROOT_DIR, 'tools', 'valgrind', 'asan', 'asan_symbolize.py')
cmd = [sys.executable, script_path]
if json_path is not None:
cmd.append('--test-summary-json-file=%s' % json_path)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698