Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1645173002: Engine test fix to keep up with SourceFactory changes. (Closed)

Created:
4 years, 10 months ago by pquitslund
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Engine test fix to keep up with SourceFactory changes. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e902b07ed4afc268449997e9ec626b8833f8d594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
4 years, 10 months ago (2016-01-28 20:56:03 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-01-28 20:56:59 UTC) #3
pquitslund
4 years, 10 months ago (2016-01-28 20:57:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e902b07ed4afc268449997e9ec626b8833f8d594 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698