Issue 164511: Merge 23048 - Fix a spell check dictionary download bug, where killing the sp...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164511: Merge 23048 - Fix a spell check dictionary download bug, where killing the sp... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
sidchat, sidchat (Google)

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 23048 - Fix a spell check dictionary download bug, where killing the spell checker while downloading the dictionary leads to a crash. This is happening for my autolanguage detection feature, which sometimes kills a spellchecker while it is downloading a dictionary file. Hopefully, this is also a fix for BUG 18743. BUG=www.crbug.com/18743 TEST=none Review URL: http://codereview.chromium.org/165175 TBR=sidchat@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23355

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -192 lines)			Patch
	MM	chrome/browser/spellchecker.h	View		10 chunks	+21 lines, -21 lines	0 comments	Download
	MM	chrome/browser/spellchecker.cc	View		6 chunks	+51 lines, -171 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2009/08/13 20:23:12, laforge wrote:
>

Expand Messages | Collapse Messages