Move SkPixelXorXfermode.h to include/client/android

Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is Android-specific

This needs to land after the Chromium CL https://codereview.chromium.org/1647953006/ (Add include/client/android to skia .gn & .gypi files)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645093002

Committed: https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614

Committed: https://skia.googlesource.com/skia/+/188d44c5496c64fe06e02ba00a3e983200fa6c88

[robertphillips, 2016-01-28 16:53:43]

Description was changed from

==========
Move SkPixelXorXfermode.h to include/client/android
==========

to

==========
Move SkPixelXorXfermode.h to include/client/android
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-28 16:54:35]

Description was changed from

==========
Move SkPixelXorXfermode.h to include/client/android
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkPixelXorXfermode.h to include/client/android
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-28 16:54:35]

robertphillips@google.com changed reviewers:
+ reed@google.com, scroggo@google.com

[robertphillips, 2016-01-28 16:55:07]

Description was changed from

==========
Move SkPixelXorXfermode.h to include/client/android
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is
Android-specific

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-28 17:07:50]

> Move SkPixelXorXfermode.h to include/client/android

> This intended to make clients aware that the
> SkPixelXorXfermode is Android-specific

This seems like a fine thing to do. Have other files been moved there? Or is
this the first? I suppose when you say "Android-specific" you really mean
"Android framework specific"?

Looking in my source tree, I see some other things that look to be specific to
the Android framework:

- include/android
  Classes for BitmapRegionDecoder
- tools/android
  SkAndroidSDKCanvas, which I think is used for testing?
- SkFrontBufferedStream in include/utils is for Android

Should any of these be consolidated? Should SkPixelXorXfermode.cpp go in
src/android (which already exists for the files in include/android)? Should they
have their own gyp files? My guess is that at least the BRD and front buffered
stream should go in the same folder. Not sure about tools/android.

[robertphillips, 2016-01-28 18:42:36]

From offline discussions it appears the plan is:

  Migrate platform-specific headers to include/client/<platform> (e.g.,
include/client/android)
  Migrate platform-specific code to src/<platform>/* (e.g., src/android/effects)

[scroggo, 2016-01-28 20:22:28]

scroggo@google.com changed reviewers:
+ djsollen@google.com

[scroggo, 2016-01-28 20:22:29]

Robert said:
> Okay - I ran gyp_to_android.py locally and it seems to add the
> "include/client/android" directory in the right place.

I just ran locally and see it under LOCAL_C_INCLUDES, but I do not see it under
LOCAL_EXPORT_C_INCLUDE_DIRS. We need to either fix that or update
https://cs.corp.google.com/#android/frameworks/base/core/jni/Android.mk to
include include/client/android.

To do the former, you can add

'include_dirs': [
  '../include/client/android',
],

to gyp/android_framework_lib.gyp.

I don't remember why we have some includes specified in the other makefile,
rather than always depending on Skia's. Derek, any ideas?

[robertphillips, 2016-01-28 20:33:14]

Done & thanks (I never would've figured out that I needed to put something in
android_framework_lib.gyp).

[reed1, 2016-01-28 21:05:58]

api lgtm

[djsollen, 2016-01-28 21:08:08]

https://codereview.chromium.org/1645093002/diff/60001/gyp/effects.gyp
File gyp/effects.gyp (right):

https://codereview.chromium.org/1645093002/diff/60001/gyp/effects.gyp#newcode31
gyp/effects.gyp:31: '../include/effects',
I think if you add it here you don't need to add it to the
android_framework_lib.gyp.

[scroggo, 2016-01-28 21:09:58]

lgtm, either with Derek's recommendation or as is.

[robertphillips, 2016-01-29 12:49:06]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 12:49:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645093002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645093002/80001

[commit-bot: I haz the power, 2016-01-29 13:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 13:10:18]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-01-29 13:10:26]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-01-29 13:10:27]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1645093002/#ps80001
(title: "mv include from android_framework_lib.gyp to effects.gyp")

[commit-bot: I haz the power, 2016-01-29 13:10:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645093002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645093002/80001

[commit-bot: I haz the power, 2016-01-29 13:11:20]

Description was changed from

==========
Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is
Android-specific

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is
Android-specific

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614
==========

[commit-bot: I haz the power, 2016-01-29 13:11:21]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614

[robertphillips, 2016-01-29 13:34:10]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1644903004/ by robertphillips@google.com.

The reason for reverting is: GN woes.

[robertphillips, 2016-01-29 13:36:12]

Description was changed from

==========
Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is
Android-specific

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614
==========

to

==========
Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is
Android-specific

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614
==========

[robertphillips, 2016-01-29 19:25:21]

Description was changed from

==========
Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is
Android-specific

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614
==========

to

==========
Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is
Android-specific

This needs to land after the Chromium CL
https://codereview.chromium.org/1647953006/ (Add include/client/android to skia
.gn & .gypi files)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614
==========

[robertphillips, 2016-02-01 12:38:24]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-01 12:38:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645093002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645093002/120001

[commit-bot: I haz the power, 2016-02-01 12:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 12:53:04]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-02-01 12:53:29]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-02-01 12:53:29]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1645093002/#ps120001
(title: "Add include/client/android to public.bzl")

[commit-bot: I haz the power, 2016-02-01 12:53:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645093002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645093002/120001

[commit-bot: I haz the power, 2016-02-01 12:54:17]

Description was changed from

==========
Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is
Android-specific

This needs to land after the Chromium CL
https://codereview.chromium.org/1647953006/ (Add include/client/android to skia
.gn & .gypi files)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614
==========

to

==========
Move SkPixelXorXfermode.h to include/client/android

This intended to make clients aware that the SkPixelXorXfermode is
Android-specific

This needs to land after the Chromium CL
https://codereview.chromium.org/1647953006/ (Add include/client/android to skia
.gn & .gypi files)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614

Committed:
https://skia.googlesource.com/skia/+/188d44c5496c64fe06e02ba00a3e983200fa6c88
==========

[commit-bot: I haz the power, 2016-02-01 12:54:18]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/188d44c5496c64fe06e02ba00a3e983200fa6c88