Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1645073004: PDF: Fix a crash from r372196 with the print preview PDFEngine client. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, raymes
CC:
chromium-reviews, jun_fang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Fix a crash from r372196 with the print preview PDFEngine client. TEST=Print preview does not crash BUG=582345 Committed: https://crrev.com/644f4d8731599a7137de1230acc454cd813dd3ba Cr-Commit-Position: refs/heads/master@{#372360}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +4 lines, -1 line 0 comments Download
M pdf/preview_mode_client.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Lei Zhang
When I synced my Chromium build and tried to print preview, the PDF plugin in ...
4 years, 10 months ago (2016-01-29 03:25:54 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-01-29 08:23:17 UTC) #5
Lei Zhang
4 years, 10 months ago (2016-01-29 08:23:25 UTC) #6
Tom Sepez
lgtm
4 years, 10 months ago (2016-01-29 16:48:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645073004/20001
4 years, 10 months ago (2016-01-29 16:48:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-01-29 16:53:58 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 16:55:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/644f4d8731599a7137de1230acc454cd813dd3ba
Cr-Commit-Position: refs/heads/master@{#372360}

Powered by Google App Engine
This is Rietveld 408576698