Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 164507: Merge 22701 - Http Cache: Deactivate entries without having the key of the... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
rvargas1
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Merge 22701 - Http Cache: Deactivate entries without having the key of the entry to delete. The disk cache may fail to provide the key for a given entry (if there is a disk error, for instance), so we fall back to enumerate the active entries to delete this one. BUG=9952 TEST=unittest Review URL: http://codereview.chromium.org/165089 TBR=rvargas@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -7 lines) Patch
MM net/http/http_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
MM net/http/http_cache.cc View 2 chunks +17 lines, -2 lines 0 comments Download
MM net/http/http_cache_unittest.cc View 15 chunks +60 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 4 months ago (2009-08-13 20:01:59 UTC) #1
rvargas1
11 years, 4 months ago (2009-08-13 20:38:12 UTC) #2
OK

On Thu, Aug 13, 2009 at 1:01 PM, <laforge@chromium.org> wrote:

> Reviewers: rvargas,
>
> Description:
> Merge 22701 - Http Cache: Deactivate entries without having the key of
> the
> entry to delete.
>
> The disk cache may fail to provide the key for a given entry
> (if there is a disk error, for instance), so we fall back
> to enumerate the active entries to delete this one.
>
> BUG=9952
> TEST=unittest
>
> Review URL: http://codereview.chromium.org/165089
>
> TBR=rvargas@google.com
>
>
> Please review this at http://codereview.chromium.org/164507
>
> SVN Base: svn://chrome-svn/chrome/branches/195/src/
>
> Affected files:
>  MM    net/http/http_cache.h
>  MM    net/http/http_cache.cc
>  MM    net/http/http_cache_unittest.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698