Issue 164506: Re-enable the ICO chunked decoding test. Remove check for condition that is ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164506: Re-enable the ICO chunked decoding test. Remove check for condition that is ... (Closed)

Created:
11 years, 4 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Re-enable the ICO chunked decoding test. Remove check for condition that is not an invariant. I thought it was when writing the test, but after some perusal of the decoders and thought, I think the GIF and ICO decoders both can legitimately fail this condition sometimes. BUG=19263 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23351

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	webkit/tools/test_shell/image_decoder_unittest.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	webkit/tools/webcore_unit_tests/ICOImageDecoder_unittest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages