Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1645053002: dart2js cps: Refactor tracking of side effects. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Clarification Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index db1592db3216b5064fdcdb6cb4ef381eeb0ca0f7..b16f5c829a9d1a620b19e8736d7fe52c40870abf 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -269,12 +269,14 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitGetField(cps_ir.GetField node) {
String object = formatReference(node.object);
String field = node.field.name;
- return 'GetField($object.$field)';
+ String finalFlag = node.isFinal ? 'final' : 'non-final';
+ return 'GetField $object.$field $finalFlag';
}
visitGetStatic(cps_ir.GetStatic node) {
String element = node.element.name;
- return 'GetStatic($element)';
+ String finalFlag = node.isFinal ? 'final' : 'non-final';
+ return 'GetStatic $element $finalFlag';
}
visitSetStatic(cps_ir.SetStatic node) {
@@ -285,7 +287,8 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitGetLazyStatic(cps_ir.GetLazyStatic node) {
String element = node.element.name;
- return "GetLazyStatic $element";
+ String finalFlag = node.isFinal ? 'final' : 'non-final';
+ return "GetLazyStatic $element $finalFlag";
}
visitCreateBox(cps_ir.CreateBox node) {
@@ -361,7 +364,8 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitGetLength(cps_ir.GetLength node) {
String object = formatReference(node.object);
- return 'GetLength $object';
+ String finalFlag = node.isFinal ? 'final' : 'non-final';
+ return 'GetLength $object $finalFlag';
}
visitGetIndex(cps_ir.GetIndex node) {

Powered by Google App Engine
This is Rietveld 408576698