pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart - Issue 1645053002: dart2js cps: Refactor tracking of side effects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

Issue 1645053002: dart2js cps: Refactor tracking of side effects. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Treat named argument as optional Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

index 8ec5743eca62b7a85efaec5a0e2462d129b0d733..23905ce667bae4b0c41e41cb32e7a60d280212a5 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

@@ -2588,7 +2588,8 @@ class IrBuilder {

}

ir.Primitive buildFieldGet(ir.Primitive receiver, FieldElement target) {

- return addPrimitive(new ir.GetField(receiver, target));

+ return addPrimitive(new ir.GetField(receiver, target,

+ isFinal: program.fieldNeverChanges(target)));

}

void buildFieldSet(ir.Primitive receiver,