Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 1645043002: Don't give 'order' semantic errors special treatment (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't give 'order' semantic errors special treatment Just set the parse status to the (new) error code for "zero value" or "negative value" and let it propagate. This makes SVGDocumentExtensions::reportWarning dead, so remove it. BUG=231612 Committed: https://crrev.com/ac5bc1a7e0cd4a67929b77d66d0d0f7782482c2d Cr-Commit-Position: refs/heads/master@{#372176}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
fs
4 years, 10 months ago (2016-01-28 16:33:51 UTC) #2
f(malita)
lgtm
4 years, 10 months ago (2016-01-28 16:39:32 UTC) #3
pdr.
lgtm
4 years, 10 months ago (2016-01-28 19:31:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645043002/1
4 years, 10 months ago (2016-01-28 19:33:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 21:44:37 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 21:45:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac5bc1a7e0cd4a67929b77d66d0d0f7782482c2d
Cr-Commit-Position: refs/heads/master@{#372176}

Powered by Google App Engine
This is Rietveld 408576698