Unescape username/passwords obtained from URLs before using them for HTTP aut...

net/http/http_network_transaction.h

Index: net/http/http_network_transaction.h
===================================================================
--- net/http/http_network_transaction.h	(revision 23194)
+++ net/http/http_network_transaction.h	(working copy)
@@ -62,6 +62,8 @@
 
  private:
   FRIEND_TEST(HttpNetworkTransactionTest, ResetStateForRestart);
+  FRIEND_TEST(HttpNetworkTransactionTest, GetIdentifyFromUrl);
+  FRIEND_TEST(HttpNetworkTransactionTest, GetIdentifyFromUrl_UTF8);
 
   // This version of IOBuffer lets us use a string as the real storage and
   // "move" the data pointer inside the string before using it to do actual IO.
@@ -259,6 +261,12 @@
   // was found.
   bool SelectNextAuthIdentityToTry(HttpAuth::Target target);
 
+  // Extract the unescaped username/password from |url|, saving the results
+  // into |*username| and |*password|.
+  static void GetIdentifyFromUrl(const GURL& url,

[wtc, 2009/08/13 21:37:36]

Consider moving this method to net_util.h, so that we don't
need to add new FRIEND_TESTs.

Nit: Use "URL" in the function's name.

+                                 std::wstring* username,
+                                 std::wstring* password);
+
   // Searches the auth cache for an entry that encompasses the request's path.
   // If such an entry is found, updates auth_identity_[target] and
   // auth_handler_[target] with the cache entry's data and returns true.