Trace VM service requests

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 
 #include "vm/compiler.h"
 #include "vm/coverage.h"
@@ skipping 10 matching lines @@
 #include "vm/object_id_ring.h"
 #include "vm/object_store.h"
 #include "vm/port.h"
 #include "vm/profiler.h"
 #include "vm/stack_frame.h"
 #include "vm/symbols.h"
 
 
 namespace dart {
 
+DEFINE_FLAG(bool, trace_service, false, "Trace VM service requests.");
+
 struct ResourcesEntry {
   const char* path_;
   const char* resource_;
   int length_;
 };
 
 extern ResourcesEntry __service_resources_[];
 
 class Resources {
  public:
@@ skipping 391 matching lines @@
 typedef bool (*RootMessageHandler)(JSONStream* stream);
 
 struct RootMessageHandlerEntry {
   const char* command;
   RootMessageHandler handler;
 };
 
 static RootMessageHandler FindRootMessageHandler(const char* command);
 
 
-static void PostReply(JSONStream* js) {
-  Dart_Port reply_port = js->reply_port();
-  ASSERT(reply_port != ILLEGAL_PORT);
-  js->set_reply_port(ILLEGAL_PORT);  // Prevent double replies.
-
-  const String& reply = String::Handle(String::New(js->ToCString()));
-  ASSERT(!reply.IsNull());
-
-  uint8_t* data = NULL;
-  MessageWriter writer(&data, &allocator);
-  writer.WriteMessage(reply);
-  PortMap::PostMessage(new Message(reply_port, data,
-                                   writer.BytesWritten(),
-                                   Message::kNormalPriority));
-}
-
-
-static void SetupJSONStream(JSONStream* js, Zone* zone,
-                            const Instance& reply_port,
-                            const GrowableObjectArray& path,
-                            const GrowableObjectArray& option_keys,
-                            const GrowableObjectArray& option_values) {
-  // Setup the reply port.
-  const Object& id_obj = Object::Handle(
-      DartLibraryCalls::PortGetId(reply_port));
-  if (id_obj.IsError()) {
-    Exceptions::PropagateError(Error::Cast(id_obj));
-  }
-  const Integer& id = Integer::Cast(id_obj);
-  Dart_Port port = static_cast<Dart_Port>(id.AsInt64Value());
-  ASSERT(port != ILLEGAL_PORT);
-  js->set_reply_port(port);
-
-  // Setup JSONStream arguments and options. The arguments and options
-  // are zone allocated and will be freed immediately after handling the
-  // message.
-  const char** arguments = zone->Alloc<const char*>(path.Length());
-  String& string_iterator = String::Handle();
-  for (intptr_t i = 0; i < path.Length(); i++) {
-    string_iterator ^= path.At(i);
-    arguments[i] = zone->MakeCopyOfString(string_iterator.ToCString());
-  }
-  js->SetArguments(arguments, path.Length());
-  if (option_keys.Length() > 0) {
-    const char** option_keys_native =
-        zone->Alloc<const char*>(option_keys.Length());
-    const char** option_values_native =
-        zone->Alloc<const char*>(option_keys.Length());
-    for (intptr_t i = 0; i < option_keys.Length(); i++) {
-      string_iterator ^= option_keys.At(i);
-      option_keys_native[i] =
-          zone->MakeCopyOfString(string_iterator.ToCString());
-      string_iterator ^= option_values.At(i);
-      option_values_native[i] =
-          zone->MakeCopyOfString(string_iterator.ToCString());
-    }
-    js->SetOptions(option_keys_native, option_values_native,
-                  option_keys.Length());
-  }
-}
-
-
 static void PrintArgumentsAndOptions(const JSONObject& obj, JSONStream* js) {
   JSONObject jsobj(&obj, "message");
   {
     JSONArray jsarr(&jsobj, "arguments");
     for (intptr_t i = 0; i < js->num_arguments(); i++) {
       jsarr.AddValue(js->GetArgument(i));
     }
   }
   {
     JSONArray jsarr(&jsobj, "option_keys");
@@ skipping 52 matching lines @@
     path ^= message.At(1);
     option_keys ^= message.At(2);
     option_values ^= message.At(3);
 
     ASSERT(!path.IsNull());
     ASSERT(!option_keys.IsNull());
     ASSERT(!option_values.IsNull());
     // Same number of option keys as values.
     ASSERT(option_keys.Length() == option_values.Length());
 
-    String& pathSegment = String::Handle();
+    String& path_segment = String::Handle();
     if (path.Length() > 0) {
-      pathSegment ^= path.At(0);
+      path_segment ^= path.At(0);
     } else {
-      pathSegment ^= Symbols::Empty().raw();
+      path_segment ^= Symbols::Empty().raw();
     }
-    ASSERT(!pathSegment.IsNull());
+    ASSERT(!path_segment.IsNull());
+    const char* path_segment_c = path_segment.ToCString();
 
     IsolateMessageHandler handler =
-        FindIsolateMessageHandler(pathSegment.ToCString());
+        FindIsolateMessageHandler(path_segment_c);
     {
       JSONStream js;
-      SetupJSONStream(&js, zone.GetZone(),
-                      reply_port, path, option_keys, option_values);
+      js.Setup(zone.GetZone(), reply_port, path, option_keys, option_values);
+
       if (handler == NULL) {
         PrintError(&js, "Unrecognized path");
-        PostReply(&js);
+        js.PostReply();
       } else {
         if (handler(isolate, &js)) {
           // Handler returns true if the reply is ready to be posted.
-          PostReply(&js);
+          js.PostReply();
         }
       }
     }
   }
 }
 
 
 static bool HandleIsolate(Isolate* isolate, JSONStream* js) {
   isolate->PrintToJSONStream(js);
   return true;
@@ skipping 503 matching lines @@
 
 static IsolateMessageHandler FindIsolateMessageHandler(const char* command) {
   intptr_t num_message_handlers = sizeof(isolate_handlers) /
                                   sizeof(isolate_handlers[0]);
   for (intptr_t i = 0; i < num_message_handlers; i++) {
     const IsolateMessageHandlerEntry& entry = isolate_handlers[i];
     if (!strcmp(command, entry.command)) {
       return entry.handler;
     }
   }
+  if (FLAG_trace_service) {
+    OS::Print("Service has no isolate message handler for <%s>\n", command);
+  }
   return NULL;
 }
 
 
 void Service::HandleRootMessage(const Instance& msg) {
   Isolate* isolate = Isolate::Current();
   ASSERT(!msg.IsNull());
   ASSERT(msg.IsGrowableObjectArray());
 
   {
@@ skipping 14 matching lines @@
     option_values ^= message.At(3);
 
     ASSERT(!path.IsNull());
     ASSERT(!option_keys.IsNull());
     ASSERT(!option_values.IsNull());
     // Path always has at least one entry in it.
     ASSERT(path.Length() > 0);
     // Same number of option keys as values.
     ASSERT(option_keys.Length() == option_values.Length());
 
-    String& pathSegment = String::Handle();
-    pathSegment ^= path.At(0);
-    ASSERT(!pathSegment.IsNull());
+    String& path_segment = String::Handle();
+    path_segment ^= path.At(0);
+    ASSERT(!path_segment.IsNull());
+    const char* path_segment_c = path_segment.ToCString();
+    RootMessageHandler handler =
+        FindRootMessageHandler(path_segment_c);
 
-    RootMessageHandler handler =
-        FindRootMessageHandler(pathSegment.ToCString());
     {
       JSONStream js;
-      SetupJSONStream(&js, zone.GetZone(),
-                      reply_port, path, option_keys, option_values);
+      js.Setup(zone.GetZone(), reply_port, path, option_keys, option_values);
       if (handler == NULL) {
         PrintError(&js, "Unrecognized path");
-        PostReply(&js);
+        js.PostReply();
       } else {
         if (handler(&js)) {
           // Handler returns true if the reply is ready to be posted.
-          PostReply(&js);
+          js.PostReply();
         }
       }
     }
   }
 }
 
 
 static bool HandleRootEcho(JSONStream* js) {
   JSONObject jsobj(js);
   jsobj.AddProperty("type", "message");
@@ skipping 18 matching lines @@
 
 static RootMessageHandler FindRootMessageHandler(const char* command) {
   intptr_t num_message_handlers = sizeof(root_handlers) /
                                   sizeof(root_handlers[0]);
   for (intptr_t i = 0; i < num_message_handlers; i++) {
     const RootMessageHandlerEntry& entry = root_handlers[i];
     if (!strcmp(command, entry.command)) {
       return entry.handler;
     }
   }
+  if (FLAG_trace_service) {
+    OS::Print("Service has no root message handler for <%s>\n", command);
+  }
   return NULL;
 }
 
 }  // namespace dart