src/gpu/gl/GrGLCaps.cpp - Issue 1645013002: Revert "Enable GL_CHROMIUM_bind_uniform_location, command buffer is fixed"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLCaps.cpp

Issue 1645013002: Revert "Enable GL_CHROMIUM_bind_uniform_location, command buffer is fixed" (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/gl/GrGLCaps.cpp

diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp

index 237412a7fcb7cdf8a5568d120121a74e9dbe0287..0bfcc39236889c12a8cc760f6d9796c30463f5b5 100644

--- a/src/gpu/gl/GrGLCaps.cpp

+++ b/src/gpu/gl/GrGLCaps.cpp

@@ -207,7 +207,11 @@ void GrGLCaps::init(const GrContextOptions& contextOptions,

}

+#if 0 // Disabled due to https://bug.skia.org/4454

fBindUniformLocationSupport = ctxInfo.hasExtension("GL_CHROMIUM_bind_uniform_location");

+#else

+ fBindUniformLocationSupport = false;

+#endif

if (ctxInfo.hasExtension("GL_OES_EGL_image_external")) {

if (ctxInfo.glslGeneration() == k110_GrGLSLGeneration) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »