Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 1645003003: Script to load a list of URLs in a loop and save traces. (Closed)

Created:
4 years, 10 months ago by pasko
Modified:
4 years, 10 months ago
Reviewers:
Benoit L, mattcary
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Script to load a list of URLs in a loop and save traces. BUG=582080 Committed: https://crrev.com/6f4d9bc54affbe4eb8a26adc5121481093e1e886 Cr-Commit-Position: refs/heads/master@{#372111}

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressed comments by mattcary #

Patch Set 3 : silence pylint for unused vars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
A tools/android/loading/run_sandwich.py View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
A tools/android/loading/sandwich_jobs/wikipedia.json View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
pasko
PTaL. Presubmit failed in content_classification_lens_unittest. Ignored it for now: I am as stubborn as to ...
4 years, 10 months ago (2016-01-28 15:01:11 UTC) #3
mattcary
lgtm https://codereview.chromium.org/1645003003/diff/1/tools/android/loading/run_sandwich.py File tools/android/loading/run_sandwich.py (right): https://codereview.chromium.org/1645003003/diff/1/tools/android/loading/run_sandwich.py#newcode71 tools/android/loading/run_sandwich.py:71: with open(file_name, 'w') as f: Could use gzip.GzipFile ...
4 years, 10 months ago (2016-01-28 15:35:35 UTC) #4
Benoit L
On 2016/01/28 15:35:35, mattcary wrote: > lgtm > > https://codereview.chromium.org/1645003003/diff/1/tools/android/loading/run_sandwich.py > File tools/android/loading/run_sandwich.py (right): > ...
4 years, 10 months ago (2016-01-28 15:45:41 UTC) #5
pasko
lizeb: mattcary: thanks for quick review On 2016/01/28 15:45:41, Benoit L wrote: > Any reason ...
4 years, 10 months ago (2016-01-28 15:48:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645003003/20001
4 years, 10 months ago (2016-01-28 15:50:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/140077)
4 years, 10 months ago (2016-01-28 16:01:54 UTC) #11
pasko
pylint complains about unused variables, silenced by renaming to '_' and removing
4 years, 10 months ago (2016-01-28 16:38:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645003003/40001
4 years, 10 months ago (2016-01-28 16:39:52 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-28 17:04:16 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 17:06:01 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6f4d9bc54affbe4eb8a26adc5121481093e1e886
Cr-Commit-Position: refs/heads/master@{#372111}

Powered by Google App Engine
This is Rietveld 408576698