third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 1644993002: Initialize UserGestureIndicator for IME commitText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1644993002: Initialize UserGestureIndicator for IME commitText. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Writing unit test for the new approach Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index e91eee8f9885e38fb5e7234c829d9f463453fbdb..179807065fcfd743d23c63587c391b8b4b192080 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -3216,4 +3216,21 @@ TEST_F(WebViewTest, WebSubstringUtil)

}

#endif

+#if OS(ANDROID)

aelias_OOO_until_Jul13 2016/02/08 22:06:04 As far as I can tell, this test should pass on eve

+TEST_F(WebViewTest, PasswordFieldEditingIsUserGesture)

+ URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("input_field_password.html"));

+ MockAutofillClient client;

+ WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "input_field_password.html", true);

+ WebLocalFrameImpl* frame = toWebLocalFrameImpl(webView->mainFrame());

+ frame->setAutofillClient(&client);

+ webView->setInitialFocus(false);

+ EXPECT_TRUE(webView->confirmComposition(WebString::fromUTF8(std::string("hello").c_str())));

+ EXPECT_EQ(1, client.textChangesFromUserGesture());

+ EXPECT_FALSE(UserGestureIndicator::processingUserGesture());

+ frame->setAutofillClient(0);

+#endif

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »