git_cl.py - Issue 1644973002: Skip deleted files in git cl format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 1644973002: Skip deleted files in git cl format (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 5441c1801b0fc1a92a86588195f108a4d710f391..2d915b0b7f3a67db26a06344e23a4ba25c8320c8 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -3529,6 +3529,8 @@ def CMDformat(parser, args):

changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)

diff_output = RunGit(changed_files_cmd)

diff_files = diff_output.splitlines()

+ # Filter out files deleted by this CL

+ diff_files = [x for x in diff_files if os.path.isfile(x)]

clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]

python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]

« no previous file with comments | « no previous file | no next file » | no next file with comments »