Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1644953002: [ Win7 Oilpan ] emphasis-combined-text and emphasis-vertical tests fail (Closed)

Created:
4 years, 10 months ago by Noel Gordon
Modified:
4 years, 10 months ago
Reviewers:
wkorman
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ Win7 Oilpan ] emphasis-combined-text and emphasis-vertical tests fail Oilpan is enabled on ToT, and is reading from TestExpectations and has no Expectations file of its own (for now). Mark the tests as a flake, and place them in TestExpectations "Oilpan" area of that file. They fail both in Oilpan Win Release and Debug. [ Win7 ] fast/text/emphasis-combined-text.html [ Pass Failure ] [ Win7 ] fast/text/emphasis-vertical.html [ Pass Failure ] since the following expectation already existed, and were retained for issue 521730. crbug.com/521730 [ Win10 ] fast/text/emphasis-combined-text.html [ Failure ] crbug.com/521730 [ Win10 ] fast/text/emphasis-complex.html [ Failure ] TBR=wkorman@chromium.org BUG=574660 NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/158970d393286a33d1291629768a2a7e87562d7a Cr-Commit-Position: refs/heads/master@{#372076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Noel Gordon
4 years, 10 months ago (2016-01-28 11:52:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644953002/1
4 years, 10 months ago (2016-01-28 11:52:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 11:53:42 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 11:54:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/158970d393286a33d1291629768a2a7e87562d7a
Cr-Commit-Position: refs/heads/master@{#372076}

Powered by Google App Engine
This is Rietveld 408576698