Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1644943003: Run blink_*_unittests, wtf_unittests on the mac asan bot. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run blink_*_unittests, wtf_unittests on the mac asan bot. All three run fine on the ClangToTMacASan bot, and on the main memory waterfall linux asan bot. BUG=none R=thestig@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/eedb09383b51aca41f5005e7e9e44dd5a9ed5a1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M testing/buildbot/chromium.memory.json View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Nico
webkit_unit_tests stopped passing on the tot bot yesterday, hence me remembering that CL :-(
4 years, 10 months ago (2016-01-28 20:29:30 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-01-28 21:58:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644943003/1
4 years, 10 months ago (2016-01-28 22:06:28 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eedb09383b51aca41f5005e7e9e44dd5a9ed5a1a Cr-Commit-Position: refs/heads/master@{#372184}
4 years, 10 months ago (2016-01-28 22:29:32 UTC) #8
Nico
Committed patchset #1 (id:1) manually as eedb09383b51aca41f5005e7e9e44dd5a9ed5a1a (presubmit successful).
4 years, 10 months ago (2016-01-28 22:30:04 UTC) #10
Dirk Pranke
4 years, 10 months ago (2016-01-28 22:32:16 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698