Issue 164494: Fix SyncSetupWizard test again; the order of operations when the HtmlDialogVi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164494: Fix SyncSetupWizard test again; the order of operations when the HtmlDialogVi... (Closed)

Created:
11 years, 4 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
Munjal (Google)

CC:
chromium-reviews_googlegroups.com, ncarter (slow), Ben Goodger (Google), tim (not reviewing), idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix SyncSetupWizard test again; the order of operations when the HtmlDialogView infrastructure closes a dialog is a bit different from what I was simulating in this test. It goes 1) obtain handlers from delegate. 2) delete delegate. 3) delete handlers. Also add a virtual dtor to TestBrowserWindow. BUG=19002 TEST=SyncSetupWizardTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23414

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -28 lines)			Patch
	M	chrome/browser/views/sync/sync_setup_wizard_unittest.cc	View	1 2 3	12 chunks	+46 lines, -27 lines	0 comments	Download
	M	chrome/test/test_browser_window.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 164494: Fix SyncSetupWizard test again; the order of operations when the HtmlDialogVi... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Messages