Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/search_engines/search_terms_data.h

Issue 164493005: Move SearchTermsData::ForceInstantResultsParam() to chrome::ForceInstantResultsParam(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed nits Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/search_unittest.cc ('k') | chrome/browser/search_engines/search_terms_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/search_terms_data.h
diff --git a/chrome/browser/search_engines/search_terms_data.h b/chrome/browser/search_engines/search_terms_data.h
index 28f45727a371ed08cc4dfecb4380f2c73a5bb19e..feee80fec956c8f7cce9e57527d4a2fd098960d5 100644
--- a/chrome/browser/search_engines/search_terms_data.h
+++ b/chrome/browser/search_engines/search_terms_data.h
@@ -51,16 +51,6 @@ class SearchTermsData {
// This implementation returns the empty string.
virtual std::string GetSuggestRequestIdentifier() const;
- // Returns a string that will cause the search results page to update
- // incrementally. Currently, Instant Extended passes a different param to
- // search results pages that also has this effect, so by default this function
- // returns the empty string when Instant Extended is enabled. However, when
- // doing instant search result prerendering, we still need to pass this param,
- // as Instant Extended does not cause incremental updates by default for the
- // prerender page. Callers should set |for_prerender| in this case to force
- // the returned string to be non-empty.
- virtual std::string ForceInstantResultsParam(bool for_prerender) const;
-
// Returns a string indicating whether a non-default theme is active,
// suitable for adding as a query string param to the homepage. This only
// applies if Instant Extended is enabled. Returns an empty string otherwise.
@@ -85,8 +75,6 @@ class UIThreadSearchTermsData : public SearchTermsData {
virtual std::string GetSearchClient() const OVERRIDE;
virtual std::string GetSuggestClient() const OVERRIDE;
virtual std::string GetSuggestRequestIdentifier() const OVERRIDE;
- virtual std::string ForceInstantResultsParam(
- bool for_prerender) const OVERRIDE;
virtual std::string NTPIsThemedParam() const OVERRIDE;
// Used by tests to override the value for the Google base URL. Passing the
« no previous file with comments | « chrome/browser/search/search_unittest.cc ('k') | chrome/browser/search_engines/search_terms_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698