Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 164493005: Move SearchTermsData::ForceInstantResultsParam() to chrome::ForceInstantResultsParam(). (Closed)

Created:
6 years, 10 months ago by kmadhusu
Modified:
6 years, 10 months ago
Reviewers:
Peter Kasting, Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su
Visibility:
Public.

Description

Move SearchTermsData::ForceInstantResultsParam() to chrome::ForceInstantResultsParam(). Follow up of crrev.com/151813002. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251456

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Patch Set 3 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -37 lines) Patch
M chrome/browser/autocomplete/history_url_provider.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/search/search.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/search/search.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/search_terms_data.h View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/search_engines/search_terms_data.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/search_engines/template_url.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
kmadhusu
jered@: Please review chrome/browser/search/* changes. pkasting@: Please review chrome/browser/autocomplete/* and chrome/browser/search_engines/* changes. Thanks.
6 years, 10 months ago (2014-02-14 01:19:03 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/164493005/diff/1/chrome/browser/search/search.cc File chrome/browser/search/search.cc (right): https://codereview.chromium.org/164493005/diff/1/chrome/browser/search/search.cc#newcode375 chrome/browser/search/search.cc:375: return (for_prerender || !IsInstantExtendedAPIEnabled()) ? "ion=1&" : Nit: ...
6 years, 10 months ago (2014-02-14 05:30:00 UTC) #2
Jered
On 2014/02/14 05:30:00, Peter Kasting wrote: > LGTM > > https://codereview.chromium.org/164493005/diff/1/chrome/browser/search/search.cc > File chrome/browser/search/search.cc (right): ...
6 years, 10 months ago (2014-02-14 16:26:00 UTC) #3
kmadhusu
https://codereview.chromium.org/164493005/diff/1/chrome/browser/search/search.cc File chrome/browser/search/search.cc (right): https://codereview.chromium.org/164493005/diff/1/chrome/browser/search/search.cc#newcode375 chrome/browser/search/search.cc:375: return (for_prerender || !IsInstantExtendedAPIEnabled()) ? "ion=1&" : On 2014/02/14 ...
6 years, 10 months ago (2014-02-14 18:24:04 UTC) #4
kmadhusu
The CQ bit was checked by kmadhusu@chromium.org
6 years, 10 months ago (2014-02-14 18:24:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/164493005/200001
6 years, 10 months ago (2014-02-14 18:24:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 20:22:17 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264499
6 years, 10 months ago (2014-02-14 20:22:17 UTC) #8
kmadhusu
The CQ bit was checked by kmadhusu@chromium.org
6 years, 10 months ago (2014-02-14 20:54:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/164493005/200001
6 years, 10 months ago (2014-02-14 20:55:47 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 00:34:09 UTC) #11
Message was sent while issue was closed. 
Change committed as 251456

Powered by Google App Engine
This is Rietveld 408576698