Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1644903004: Revert of Move SkPixelXorXfermode.h to include/client/android (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
Reviewers:
scroggo, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move SkPixelXorXfermode.h to include/client/android (patchset #5 id:80001 of https://codereview.chromium.org/1645093002/ ) Reason for revert: GN woes Original issue's description: > Move SkPixelXorXfermode.h to include/client/android > > This intended to make clients aware that the SkPixelXorXfermode is Android-specific > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645093002 > > Committed: https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614 TBR=scroggo@google.com,reed@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/6b2c3461b0c109897b4699bda0f7bfdb9c37e744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -445 lines) Patch
M gyp/effects.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/effects.gypi View 2 chunks +2 lines, -3 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/ports.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D include/client/android/SkPixelXorXfermode.h View 1 chunk +0 lines, -48 lines 0 comments Download
A include/effects/SkPixelXorXfermode.h View 1 chunk +48 lines, -0 lines 0 comments Download
D src/android/effects/SkPixelXorXfermode.cpp View 1 chunk +0 lines, -390 lines 0 comments Download
A src/effects/SkPixelXorXfermode.cpp View 1 chunk +390 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Move SkPixelXorXfermode.h to include/client/android
4 years, 10 months ago (2016-01-29 13:34:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644903004/1
4 years, 10 months ago (2016-01-29 13:34:18 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 13:34:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6b2c3461b0c109897b4699bda0f7bfdb9c37e744

Powered by Google App Engine
This is Rietveld 408576698