added support for more features in JSON (blurs, dashing, different path fill types, etc.)

added support for more features in JSON (blurs, dashing, different path fill types, etc.)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644903003

Committed: https://skia.googlesource.com/skia/+/78fc22af41a5118963a8f7253758111b05b9700e

[ethannicholas, 2016-01-28 21:05:51]

Description was changed from

==========
added support for more features in JSON (blurs, dashing, different path fill
types, etc.)
==========

to

==========
added support for more features in JSON (blurs, dashing, different path fill
types, etc.)
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[ethannicholas, 2016-01-28 21:07:23]

ethannicholas@google.com changed reviewers:
+ jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-01-29 13:45:38]

On 2016/01/28 21:07:23, ethannicholas wrote:

lgtm

[ethannicholas, 2016-01-29 14:51:53]

The CQ bit was checked by ethannicholas@google.com

[commit-bot: I haz the power, 2016-01-29 14:51:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644903003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644903003/1

[commit-bot: I haz the power, 2016-01-29 15:15:11]

Description was changed from

==========
added support for more features in JSON (blurs, dashing, different path fill
types, etc.)
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
added support for more features in JSON (blurs, dashing, different path fill
types, etc.)
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/78fc22af41a5118963a8f7253758111b05b9700e
==========

[commit-bot: I haz the power, 2016-01-29 15:15:11]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/78fc22af41a5118963a8f7253758111b05b9700e

[jcgregorio, 2016-01-29 15:27:30]

On 2016/01/28 at 21:07:23, ethannicholas wrote:
> 

Currently failing to build skiaserve with:

../../tools/json/SkJSONRenderer.cpp: In member function ‘void
SkJSONRenderer::Renderer::getPaint(Json::Value&, SkPaint*)’:
../../tools/json/SkJSONRenderer.cpp:185:24: error: variable ‘textAlign’ set but
not used [-Werror=unused-but-set-variable]
         SkPaint::Align textAlign;
                        ^
cc1plus: all warnings being treated as errors

[ethannicholas, 2016-01-29 15:39:09]

On 2016/01/29 15:27:30, jcgregorio wrote:
> On 2016/01/28 at 21:07:23, ethannicholas wrote:
> > 
> 
> Currently failing to build skiaserve with:
> 
> ../../tools/json/SkJSONRenderer.cpp: In member function ‘void
> SkJSONRenderer::Renderer::getPaint(Json::Value&, SkPaint*)’:
> ../../tools/json/SkJSONRenderer.cpp:185:24: error: variable ‘textAlign’ set
but
> not used [-Werror=unused-but-set-variable]
>          SkPaint::Align textAlign;
>                         ^
> cc1plus: all warnings being treated as errors

Just TBR'd you for a fix to this.