Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1644893002: Revert of Improve performance of Character::isCJKIdeographOrSymbol by using trie tree (Closed)

Created:
4 years, 11 months ago by kojii
Modified:
4 years, 11 months ago
Reviewers:
drott, eae, Dirk Pranke
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, danakj, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve performance of Character::isCJKIdeographOrSymbol by using trie tree (patchset #24 id:460001 of https://codereview.chromium.org/1541393003/ ) Reason for revert: GN asan and tsan are broken, wasn't aware bots are running GYP only. Reverting until we can figure out what to do with GN asan/tsan and probably msan. Original issue's description: > Improve performance of Character::isCJKIdeographOrSymbol by using trie tree > > This patch is another effort to make Character::isCJKIdeographOrSymbol > faster. > > The previous CL[1] made it faster by ~90% for codepoints below U+2020, > but codepoints abvoe U+2020 were not as fast. This CL makes all > codepoints faster, as fast as ICU functions. > > Before After Improve ICU > All 2569 => 292 88% 298 > ASCII 68 => 68 0% 160 > Han 2958 => 263 91% 344 > Hira 258 => 11 95% 14 > Arabic 37 => 32 13% 44 > * # of code points and iterations vary by rows. > > The previous CL[1] clarified that binary search is not as fast as ICU > functions such as uscript_getScript(). This patch changes to use > UTrie2, which is the data structure ICU property functions use. > > In addition in this patch: > * U+2763 and U+2764 are added as requested by drott@. > * Character::isUprightInMixedVertical() was switched to UTrie2 too. > * Character::isCJKIdeograph() was removed because it is no longer used. > > [1] https://codereview.chromium.org/1545073002 > > BUG=571943 > > Committed: https://crrev.com/e6dc3f425137021f39eddbbeb2035273ce36f986 > Cr-Commit-Position: refs/heads/master@{#371917} TBR=eae@chromium.org,drott@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=571943 Committed: https://crrev.com/3aad18968cc1cef197deb464c48bcdcd2f6a7080 Cr-Commit-Position: refs/heads/master@{#372004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -1147 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 3 chunks +4 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/Character.h View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Character.cpp View 3 chunks +240 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/platform/fonts/CharacterData.cpp View 1 chunk +0 lines, -634 lines 0 comments Download
D third_party/WebKit/Source/platform/fonts/CharacterDataGenerator.cpp View 1 chunk +0 lines, -337 lines 0 comments Download
D third_party/WebKit/Source/platform/fonts/CharacterProperty.h View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/CharacterTest.cpp View 2 chunks +9 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/platform_generated.gyp View 2 chunks +0 lines, -53 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kojii
Created Revert of Improve performance of Character::isCJKIdeographOrSymbol by using trie tree
4 years, 11 months ago (2016-01-28 04:05:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644893002/1
4 years, 11 months ago (2016-01-28 04:05:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 04:07:19 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 04:08:48 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3aad18968cc1cef197deb464c48bcdcd2f6a7080
Cr-Commit-Position: refs/heads/master@{#372004}

Powered by Google App Engine
This is Rietveld 408576698