third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp - Issue 1644883002: Add additive animation support for CSS property translate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

Issue 1644883002: Add additive animation support for CSS property translate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_propertyInterpolationTypesMapping

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html ('K') | « third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html ('k') | third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.h » ('j') | third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

index cdaadc631d0c8a00a7fc42f82ddb8e796a54ccfe..704dff160f1a06e12fbd78a2f05b3fee571c5f13 100644

--- a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

@@ -227,8 +227,9 @@ static double clampToRange(double x, ValueRange range)

static Length createLength(double pixels, double percentage, bool hasPercentage, ValueRange range)

{

- ASSERT(hasPercentage || percentage == 0);

- if (pixels && hasPercentage)

+ if (percentage != 0)

+ hasPercentage = true;

+ if (pixels != 0 && hasPercentage)

return Length(CalculationValue::create(PixelsAndPercent(pixels, percentage), range));

if (hasPercentage)

return Length(clampToRange(percentage, range), Percent);