Make build's DEPS file git-only

Make build's DEPS file git-only

R=hinoka@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/build/+/53bbed82e61cffcc90a0e91698f936ea1f060d85

[hinoka, 2016-01-28 23:34:06]

I know gclient used to fall back to DEPS if .DEPS.git doesn't exist, and if
that's still the case I think this will work.

lgtm because I think this will work.

[chromium-reviews, 2016-01-29 09:27:28]

DEPS is intentionally broken (throws an exception), only .DEPS.git should
be used. All deps repos are purely on Git now.

On Fri, Jan 29, 2016, 00:34  <hinoka@chromium.org> wrote:

>
> I know gclient used to fall back to DEPS if .DEPS.git doesn't exist, and if
> that's still the case I think this will work.
>
> lgtm because I think this will work.
> https://codereview.chromium.org/1644863004/
>
> --
Sergiy Byelozyorov | Software Engineer | sergiyb@google.com

Google Germany GmbH
Dienerstraße 12
80331 München

AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg | Geschäftsführer:
Matthew Scott Sucherman, Paul Terence Manicle

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sergiy Byelozyorov, 2016-01-29 09:40:15]

On 2016/01/29 09:27:28, chromium-reviews wrote:
> DEPS is intentionally broken (throws an exception), only .DEPS.git should
> be used. All deps repos are purely on Git now.
> 
> On Fri, Jan 29, 2016, 00:34  <mailto:hinoka@chromium.org> wrote:
> 
> >
> > I know gclient used to fall back to DEPS if .DEPS.git doesn't exist, and if
> > that's still the case I think this will work.
> >
> > lgtm because I think this will work.
> > https://codereview.chromium.org/1644863004/
> >
> > --
> Sergiy Byelozyorov | Software Engineer | mailto:sergiyb@google.com
> 
> Google Germany GmbH
> Dienerstraße 12
> 80331 München
> 
> AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg | Geschäftsführer:
> Matthew Scott Sucherman, Paul Terence Manicle
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Nevermind my last message. I confused this change with another one.

[dsansome, 2016-06-29 00:59:35]

dsansome@chromium.org changed reviewers:
+ dsansome@chromium.org

[dsansome, 2016-06-29 00:59:36]

lgtm

https://codereview.chromium.org/1644863004/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1644863004/diff/1/DEPS#newcode12
DEPS:12: 'https://chromium.googlesource.com/external/boto.git'
Unindent by 2 spaces?

[agable, 2016-06-29 20:12:59]

I'm honestly not sure why this never landed. I think I was just scared. But I've
confirmed that gclient does fallback to 'DEPS' if a different deps file is
specified but doesn't exist, so this will work.

Notifying the trooper and landing today.

https://codereview.chromium.org/1644863004/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1644863004/diff/1/DEPS#newcode12
DEPS:12: 'https://chromium.googlesource.com/external/boto.git'
On 2016/06/29 at 00:59:35, dsansome wrote:
> Unindent by 2 spaces?

Done.

[agable, 2016-06-29 20:13:09]

The CQ bit was checked by agable@chromium.org

[agable, 2016-06-29 20:13:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsansome@chromium.org, hinoka@chromium.org
Link to the patchset: https://codereview.chromium.org/1644863004/#ps20001
(title: "Rebase + formatting")

[commit-bot: I haz the power, 2016-06-29 20:13:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 20:16:51]

Description was changed from

==========
Make build's DEPS file git-only

R=hinoka@chromium.org
==========

to

==========
Make build's DEPS file git-only

R=hinoka@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/53bbed82e61cffcc90a0...
==========

[commit-bot: I haz the power, 2016-06-29 20:16:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/53bbed82e61cffcc90a0...