ui/views/accessibility/ax_view_obj_wrapper.cc - Issue 1644863003: Prune invisible views from the desktop automation tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/ax_view_obj_wrapper.cc

Issue 1644863003: Prune invisible views from the desktop automation tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try hitting space (behavior changes when a tab is open). Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc ('k') | ui/views/accessibility/ax_widget_obj_wrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/accessibility/ax_view_obj_wrapper.cc

diff --git a/ui/views/accessibility/ax_view_obj_wrapper.cc b/ui/views/accessibility/ax_view_obj_wrapper.cc

index 4363d19dc71c5de9a9bcbb0239d27afdf139038d..d4a2c4325d04f9ee87296df3aef8bcdee2394125 100644

--- a/ui/views/accessibility/ax_view_obj_wrapper.cc

+++ b/ui/views/accessibility/ax_view_obj_wrapper.cc

@@ -36,6 +36,9 @@ void AXViewObjWrapper::GetChildren(

std::vector<AXAuraObjWrapper*>* out_children) {

// TODO(dtseng): Need to handle |Widget| child of |View|.

for (int i = 0; i < view_->child_count(); ++i) {

+ if (!view_->child_at(i)->visible())

+ continue;

AXAuraObjWrapper* child =

AXAuraObjCache::GetInstance()->GetOrCreate(view_->child_at(i));

out_children->push_back(child);