Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1644863002: X87: [regexp] implement case-insensitive unicode regexps. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [regexp] implement case-insensitive unicode regexps. port a2baaaac93efbdd3f2e19e66907a39a7197b8305 (r33538) original commit message: BUG= Committed: https://crrev.com/2d89015a4c90ab4758da47c9a5fdcadc2928dd2e Cr-Commit-Position: refs/heads/master@{#33568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/regexp/x87/regexp-macro-assembler-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/x87/regexp-macro-assembler-x87.cc View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-28 03:18:24 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-28 03:58:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644863002/1
4 years, 11 months ago (2016-01-28 04:02:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 04:20:19 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 04:21:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d89015a4c90ab4758da47c9a5fdcadc2928dd2e
Cr-Commit-Position: refs/heads/master@{#33568}

Powered by Google App Engine
This is Rietveld 408576698