[MD settings] add proper formatting for appearance setting of homepage as new tab page

[MD settings] add proper formatting for appearance setting of homepage as new tab page

This CL changes the radio buttons that expand when
selecting NewTabPage options in Appearance settings.

BUG=531786
Committed: https://crrev.com/9f58a9d76993815a3f2d8013f90569663da329ab
Cr-Commit-Position: refs/heads/master@{#372156}

[dschuyler, 2016-01-28 02:33:28]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-01-28 02:49:58]

Patched the CL locally, few comments regarding differences I still see compared
to the mocks.

 - There seems to be no margin between "Other" and the textbox.
 - In the mocks, when the "new tab page" radio button is selected, the textbox
next to "Other" is grayed out.
 - In the mocks, there seems to be a "^" icon on the top-right of the
sub-section to collapse it (even when the "show home button" checkbox is
checked. In the current implementation the section is expanding/collapsing based
on the checkbox value instead.
 - In the mocks, below the "Show home button" label, there is a 2nd row with
either 'www.example.com" or "New tab page" gray text.

Do you plan to address those in follow-up CLs? If so that's fine, just
mentioning them so we can keep track of the differences (feel free to copy-paste
them in the related bug if that helps).

[dschuyler, 2016-01-28 19:26:00]

On 2016/01/28 02:49:58, dpapad wrote:
> Patched the CL locally, few comments regarding differences I still see
compared
> to the mocks.
> 
>  - There seems to be no margin between "Other" and the textbox.
>  - In the mocks, when the "new tab page" radio button is selected, the textbox
> next to "Other" is grayed out.
>  - In the mocks, there seems to be a "^" icon on the top-right of the
> sub-section to collapse it (even when the "show home button" checkbox is
> checked. In the current implementation the section is expanding/collapsing
based
> on the checkbox value instead.
>  - In the mocks, below the "Show home button" label, there is a 2nd row with
> either 'www.example.com" or "New tab page" gray text.
> 
> Do you plan to address those in follow-up CLs? If so that's fine, just
> mentioning them so we can keep track of the differences (feel free to
copy-paste
> them in the related bug if that helps).


Yeah, thanks.  I'm planning on addressing those separately.  I've pasted those
notes
into the bug as suggested.

[dpapad, 2016-01-28 20:27:25]

lgtm

[dschuyler, 2016-01-28 20:28:08]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-01-28 20:29:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644853002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644853002/1

[commit-bot: I haz the power, 2016-01-28 20:36:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-28 20:38:16]

Description was changed from

==========
[MD settings] add proper formatting for appearance setting of homepage as new
tab page

This CL changes the radio buttons that expand when
selecting NewTabPage options in Appearance settings.

BUG=531786
==========

to

==========
[MD settings] add proper formatting for appearance setting of homepage as new
tab page

This CL changes the radio buttons that expand when
selecting NewTabPage options in Appearance settings.

BUG=531786

Committed: https://crrev.com/9f58a9d76993815a3f2d8013f90569663da329ab
Cr-Commit-Position: refs/heads/master@{#372156}
==========

[commit-bot: I haz the power, 2016-01-28 20:38:17]

Patchset 1 (id:??) landed as
https://crrev.com/9f58a9d76993815a3f2d8013f90569663da329ab
Cr-Commit-Position: refs/heads/master@{#372156}